carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1418: [CARBONDATA-1573] [Integration] Support Datab...
Date Thu, 09 Nov 2017 15:28:06 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1418#discussion_r149993636
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
    @@ -839,14 +841,56 @@ object CommonUtil {
        */
       def mergeIndexFiles(sparkContext: SparkContext,
           segmentIds: Seq[String],
    -      storePath: String,
    +      tablePath: String,
           carbonTable: CarbonTable): Unit = {
         if (CarbonProperties.getInstance().getProperty(
           CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT,
           CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT_DEFAULT).toBoolean) {
    -      new CarbonMergeFilesRDD(sparkContext, AbsoluteTableIdentifier.from(storePath,
    +      new CarbonMergeFilesRDD(sparkContext, AbsoluteTableIdentifier.from(tablePath,
             carbonTable.getDatabaseName, carbonTable.getFactTableName).getTablePath,
             segmentIds).collect()
         }
       }
    +
    +  /**
    +   * The default database and databases ending with .db will point to the
    +   * either either "carbon.storeLocation" or "spark.sql.warehouse.dir".
    +   *
    +   * @param storeLocation
    +   * @param databaseName
    +   * @param fixedStorePath
    +   * @return
    +   */
    +  def getValidStorePath(storeLocation: String, databaseName: String,
    +      fixedStorePath: String): String = {
    --- End diff --
    
    Use ends with .db to decide whether to use dblocation or storepath


---

Mime
View raw message