carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1418: [CARBONDATA-1573] [Integration] Support Datab...
Date Thu, 09 Nov 2017 14:33:25 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1418#discussion_r149977104
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
    @@ -885,4 +882,24 @@ public static DataTypeConverter getDataTypeConverter(Configuration
configuration
         }
         return (DataTypeConverter) ObjectSerializationUtil.convertStringToObject(converter);
       }
    +
    +  public static void setDatabaseName(Configuration configuration, String databaseName)
{
    +    if (null != databaseName) {
    +      configuration.set(DATABASE_NAME, databaseName);
    +    }
    +  }
    +
    +  public static String getDatabaseName(Configuration configuration) {
    +    return configuration.get(DATABASE_NAME);
    +  }
    +
    +  public static void setTableName(Configuration configuration, String tableName) {
    +    if (null != tableName) {
    +      configuration.set(TABLE_NAME, tableName);
    +    }
    +  }
    +
    +  public static String getTableName(Configuration configuration) {
    +    return configuration.get(TABLE_NAME);
    --- End diff --
    
    Throw exception if not set  for dbname and tablename


---

Mime
View raw message