carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1472: [WIP][CARBONDATA-1618]Table comment support f...
Date Tue, 07 Nov 2017 12:14:31 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1472#discussion_r149349120
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDescribeFormattedCommand.scala
---
    @@ -105,6 +105,10 @@ private[sql] case class CarbonDescribeFormattedCommand(
         results ++= Seq(("Table Name: ", relation.tableMeta.carbonTableIdentifier.getTableName,
""))
         results ++= Seq(("CARBON Store Path: ", relation.tableMeta.storePath, ""))
         val carbonTable = relation.tableMeta.carbonTable
    +    // Carbon table support table comment
    +    val tableComment = carbonTable.getTableInfo.getFactTable.getTableProperties
    +      .getOrDefault("comment", "")
    --- End diff --
    
    Move the `comment` as constant to CarbonCommonConstants


---

Mime
View raw message