carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1429: [CARBONDATA-1662] Make ArrayType and StructTy...
Date Tue, 07 Nov 2017 06:53:07 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149283956
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
    --- End diff --
    
    In schema.thrift, DataType is a Enum, so I think we can not get the child schema from
existing table before this PR.


---

Mime
View raw message