carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1467: [CARBONDATA-1669] Clean up code in CarbonData...
Date Tue, 07 Nov 2017 06:30:45 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1467#discussion_r149281235
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
---
    @@ -79,16 +82,45 @@ object CarbonStore {
           dbName: String,
           tableName: String,
           storePath: String,
    -      carbonTable: CarbonTable, forceTableClean: Boolean): Unit = {
    +      carbonTable: CarbonTable, forceTableClean: Boolean
    +  ): Unit = {
         LOGGER.audit(s"The clean files request has been received for $dbName.$tableName")
    +    var carbonCleanFilesLock: ICarbonLock = null
         try {
    -      DataManagementFunc.cleanFiles(dbName, tableName, storePath, carbonTable, forceTableClean)
    -      LOGGER.audit(s"Clean files operation is success for $dbName.$tableName.")
    +      val identifier = new CarbonTableIdentifier(dbName, tableName, "")
    +      carbonCleanFilesLock =
    +        CarbonLockFactory.getCarbonLockObj(identifier, LockUsage.CLEAN_FILES_LOCK)
         } catch {
           case ex: Exception =>
             sys.error(ex.getMessage)
    +      return
         }
    -    Seq.empty
    +    try {
    --- End diff --
    
    fixed


---

Mime
View raw message