carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1429: [CARBONDATA-1662] Make ArrayType and StructTy...
Date Mon, 06 Nov 2017 08:10:57 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149011999
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
           case STRUCT:
    -        return DataTypes.STRUCT;
    +        return DataTypes.createDefaultStructType();
    --- End diff --
    
    Can't we create actual array from the  child schemas here?


---

Mime
View raw message