carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1464: [WIP][CARBONDATA-1523]Pre Aggregate table sel...
Date Mon, 06 Nov 2017 06:04:59 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1464#discussion_r148997655
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala
---
    @@ -61,7 +66,7 @@ case class CreatePreAggregateTableCommand(
         val dbName = cm.databaseName
         LOGGER.audit(s"Creating Table with Database name [$dbName] and Table name [$tbName]")
         // getting the parent table
    -    val parentTable = PreAggregateUtil.getParentCarbonTable(dataFrame.logicalPlan)
    +    val parentTable = PreAggregateUtil.getParentCarbonTable(logicalPlan)
    --- End diff --
    
    most of the content of class same as `CreateTableCommand`, so better call that command
from here


---

Mime
View raw message