carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1464: [WIP][CARBONDATA-1523]Pre Aggregate table sel...
Date Mon, 06 Nov 2017 05:53:35 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1464#discussion_r148996693
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/preagg/QueryPlan.java ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.preagg;
    +
    +import java.util.List;
    +
    +/**
    + * class to maintain the query plan to select the data map tables
    + */
    +public class QueryPlan {
    +
    +  /**
    +   * List of projection columns
    +   */
    +  private List<QueryColumn> projectionColumn;
    +
    +  /**
    +   * list of aggregation columns
    +   */
    +  private List<QueryColumn> aggregationColumns;
    --- End diff --
    
    I think It is not required to separate out `aggregationColumns` , all should be part of
`projectionColumn` . Just add one method `hasAggFunc` to `QueryColumn`


---

Mime
View raw message