carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1464: [WIP][CARBONDATA-1523]Pre Aggregate table sel...
Date Mon, 06 Nov 2017 04:49:23 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1464#discussion_r148992649
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapSchema.java
---
    @@ -67,6 +92,83 @@ public void setRelationIdentifier(RelationIdentifier relationIdentifier)
{
     
       public void setChildSchema(TableSchema childSchema) {
         this.childSchema = childSchema;
    +    List<ColumnSchema> listOfColumns = this.childSchema.getListOfColumns();
    +    fillNonAggFunctionColumns(listOfColumns);
    +    fillAggFunctionColumns(listOfColumns);
    +    fillParentNameToAggregationMapping(listOfColumns);
    --- End diff --
    
    I feel all the above 3 functions doing the almost same job, why don't you combine all
of them.


---

Mime
View raw message