carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1455: [CARBONDATA-1624]Set the default value of 'ca...
Date Sun, 05 Nov 2017 02:26:44 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1455#discussion_r148946497
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -672,6 +672,9 @@ public int getNumberOfCores() {
               .getProperty(CarbonCommonConstants.NUM_CORES_LOADING,
                   CarbonCommonConstants.NUM_CORES_DEFAULT_VAL));
    --- End diff --
    
    Since now we always update the CarbonCommonConstants.NUM_CORES_LOADING value in LoadCommand,
we should not use default value here. You can use `String getProperty(String key)` directly.


---

Mime
View raw message