carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1386: [CARBONDATA-1513] bad-record for complex data...
Date Thu, 02 Nov 2017 13:01:39 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1386#discussion_r148524506
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
---
    @@ -131,6 +131,10 @@ public void getAllPrimitiveChildren(List<GenericDataType> primitiveChild)
{
         }
       }
     
    +  public GenericDataType getChildren() {
    --- End diff --
    
    It is better to add it in `GenericDataType` and override it here


---

Mime
View raw message