Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1402-carbondata@git.apache.org>
In-Reply-To: <git-pr-1402-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1402: [CARBONDATA-1539] Change data type from enum ...
Content-Type: text/plain
Message-Id: <20171012081427.07B32DF9AF@git1-us-west.apache.org>
Date: Thu, 12 Oct 2017 08:14:27 +0000 (UTC)
archived-at: Thu, 12 Oct 2017 08:14:28 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1402#discussion_r144220468
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/AbstractScannedResultCollector.java ---
    @@ -89,24 +90,23 @@ protected void fillMeasureData(Object[] msrValues, int offset,
       protected Object getMeasureData(ColumnPage dataChunk, int index,
           CarbonMeasure carbonMeasure) {
         if (!dataChunk.getNullBits().get(index)) {
    -      switch (carbonMeasure.getDataType()) {
    -        case SHORT:
    -          return (short)dataChunk.getLong(index);
    -        case INT:
    -          return (int)dataChunk.getLong(index);
    -        case LONG:
    -          return dataChunk.getLong(index);
    -        case DECIMAL:
    -          BigDecimal bigDecimalMsrValue =
    -              dataChunk.getDecimal(index);
    -          if (null != bigDecimalMsrValue && carbonMeasure.getScale() > bigDecimalMsrValue.scale()) {
    -            bigDecimalMsrValue =
    -                bigDecimalMsrValue.setScale(carbonMeasure.getScale(), RoundingMode.HALF_UP);
    -          }
    -          // convert data type as per the computing engine
    -          return DataTypeUtil.getDataTypeConverter().convertToDecimal(bigDecimalMsrValue);
    -        default:
    -          return dataChunk.getDouble(index);
    +      DataType dataType = carbonMeasure.getDataType();
    +      if (dataType == DataTypes.SHORT) {
    --- End diff --
    
    But I feel changes are small and looks good to use switch case instead of using if else. 


---