Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1402-carbondata@git.apache.org>
In-Reply-To: <git-pr-1402-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1402: [CARBONDATA-1539] Change data type from enum ...
Content-Type: text/plain
Message-Id: <20171012050840.20BB2DF9AE@git1-us-west.apache.org>
Date: Thu, 12 Oct 2017 05:08:40 +0000 (UTC)
archived-at: Thu, 12 Oct 2017 05:08:41 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1402#discussion_r144195110
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalType.java ---
    @@ -0,0 +1,32 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.datatype;
    +
    +public class DecimalType extends DataType {
    +
    +  public static final DataType DECIMAL =
    --- End diff --
    
    But decimal should not be singleton right, we should include precision and scale inside like spark does


---