Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1361-carbondata@git.apache.org>
In-Reply-To: <git-pr-1361-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1361: [CARBONDATA-1481] Add test cases for compacti...
Content-Type: text/plain
Message-Id: <20171010161109.961B1F5B20@git1-us-west.apache.org>
Date: Tue, 10 Oct 2017 16:11:09 +0000 (UTC)
archived-at: Tue, 10 Oct 2017 16:11:11 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1361#discussion_r143777369
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CompactionSupportGlobalSortParameterTest.scala ---
    @@ -0,0 +1,298 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the"License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an"AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.testsuite.datacompaction
    +
    +import java.io.{File, FilenameFilter}
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.spark.sql.Row
    +import org.apache.spark.sql.test.util.QueryTest
    +import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
    +
    +class CompactionSupportGlobalSortParameterTest extends QueryTest with BeforeAndAfterEach with BeforeAndAfterAll {
    +  val filePath: String = s"$resourcesPath/globalsort"
    +  val file1: String = resourcesPath + "/globalsort/sample1.csv"
    +  val file2: String = resourcesPath + "/globalsort/sample2.csv"
    +  val file3: String = resourcesPath + "/globalsort/sample3.csv"
    +
    +  override def beforeEach {
    +    resetConf
    +    sql("DROP TABLE IF EXISTS compaction_globalsort")
    +    sql(
    +      """
    +        | CREATE TABLE compaction_globalsort(id INT, name STRING, city STRING, age INT)
    +        | STORED BY 'org.apache.carbondata.format'
    +        | TBLPROPERTIES('SORT_COLUMNS'='city,name', 'SORT_SCOPE'='GLOBAL_SORT')
    +      """.stripMargin)
    +
    +    sql("DROP TABLE IF EXISTS carbon_localsort")
    +    sql(
    +      """
    +        | CREATE TABLE carbon_localsort(id INT, name STRING, city STRING, age INT)
    +        | STORED BY 'org.apache.carbondata.format'
    +      """.stripMargin)
    +  }
    +
    +  override def afterEach {
    +    sql("DROP TABLE IF EXISTS compaction_globalsort")
    +    sql("DROP TABLE IF EXISTS carbon_localsort")
    +  }
    +
    +  test("ENABLE_AUTO_LOAD_MERGE: false") {
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_AUTO_LOAD_MERGE, "false")
    +    for (i <- 0 until 2) {
    +      sql(s"LOAD DATA LOCAL INPATH '$file1' INTO TABLE carbon_localsort")
    +      sql(s"LOAD DATA LOCAL INPATH '$file2' INTO TABLE carbon_localsort")
    +      sql(s"LOAD DATA LOCAL INPATH '$file3' INTO TABLE carbon_localsort")
    +
    +      sql(s"LOAD DATA LOCAL INPATH '$file1' INTO TABLE compaction_globalsort OPTIONS('GLOBAL_SORT_PARTITIONS'='2')")
    +      sql(s"LOAD DATA LOCAL INPATH '$file2' INTO TABLE compaction_globalsort OPTIONS('GLOBAL_SORT_PARTITIONS'='2')")
    +      sql(s"LOAD DATA LOCAL INPATH '$file3' INTO TABLE compaction_globalsort OPTIONS('GLOBAL_SORT_PARTITIONS'='2')")
    +    }
    +    checkExistence(sql("DESCRIBE FORMATTED compaction_globalsort"), true, "global_sort")
    +
    +    checkExistence(sql("DESCRIBE FORMATTED compaction_globalsort"), true, "city,name")
    +
    +    sql("delete from table compaction_globalsort where SEGMENT.ID in (1,2,3)")
    +    sql("delete from table carbon_localsort where SEGMENT.ID in (1,2,3)")
    +    sql("ALTER TABLE compaction_globalsort COMPACT 'minor'")
    +    checkExistence(sql("SHOW SEGMENTS FOR TABLE compaction_globalsort"), false, "Compacted")
    +
    +    val segments = sql("SHOW SEGMENTS FOR TABLE compaction_globalsort")
    +    val SegmentSequenceIds = segments.collect().map { each => (each.toSeq) (0) }
    +    assert(!SegmentSequenceIds.contains("0.1"))
    +    assert(SegmentSequenceIds.length == 6)
    +
    +    checkAnswer(sql("SELECT COUNT(*) FROM compaction_globalsort"), Seq(Row(12)))
    +
    +    checkAnswer(sql("SELECT * FROM compaction_globalsort"),
    +      sql("SELECT * FROM carbon_localsort"))
    +
    +    checkExistence(sql("SHOW SEGMENTS FOR TABLE compaction_globalsort"), true, "Success")
    +    checkExistence(sql("SHOW SEGMENTS FOR TABLE compaction_globalsort"), true, "Marked for Delete")
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_AUTO_LOAD_MERGE,
    +      CarbonCommonConstants.DEFAULT_ENABLE_AUTO_LOAD_MERGE)
    +  }
    +
    +  test("ENABLE_AUTO_LOAD_MERGE: true") {
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_AUTO_LOAD_MERGE, "true")
    +    for (i <- 0 until 2) {
    +      sql(s"LOAD DATA LOCAL INPATH '$file1' INTO TABLE carbon_localsort")
    +      sql(s"LOAD DATA LOCAL INPATH '$file2' INTO TABLE carbon_localsort")
    +      sql(s"LOAD DATA LOCAL INPATH '$file3' INTO TABLE carbon_localsort")
    +
    +      sql(s"LOAD DATA LOCAL INPATH '$file1' INTO TABLE compaction_globalsort OPTIONS('GLOBAL_SORT_PARTITIONS'='2')")
    +      sql(s"LOAD DATA LOCAL INPATH '$file2' INTO TABLE compaction_globalsort OPTIONS('GLOBAL_SORT_PARTITIONS'='2')")
    +      sql(s"LOAD DATA LOCAL INPATH '$file3' INTO TABLE compaction_globalsort OPTIONS('GLOBAL_SORT_PARTITIONS'='2')")
    +    }
    +    checkExistence(sql("DESCRIBE FORMATTED compaction_globalsort"), true, "global_sort")
    +
    +    checkExistence(sql("DESCRIBE FORMATTED compaction_globalsort"), true, "city,name")
    +
    +    checkExistence(sql("SHOW SEGMENTS FOR TABLE compaction_globalsort"), true, "Compacted")
    +
    +    val segments = sql("SHOW SEGMENTS FOR TABLE compaction_globalsort")
    +    val SegmentSequenceIds = segments.collect().map { each => (each.toSeq) (0) }
    +    assert(SegmentSequenceIds.contains("0.1"))
    +    assert(SegmentSequenceIds.length == 7)
    --- End diff --
    
    why is it 7?


---