Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 696E3200D24 for ; Tue, 10 Oct 2017 03:26:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 67D321609E0; Tue, 10 Oct 2017 01:26:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A417D1609CE for ; Tue, 10 Oct 2017 03:26:44 +0200 (CEST) Received: (qmail 61185 invoked by uid 500); 10 Oct 2017 01:26:43 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 61171 invoked by uid 99); 10 Oct 2017 01:26:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 01:26:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4EC7DE8F1F; Tue, 10 Oct 2017 01:26:42 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ... Content-Type: text/plain Message-Id: <20171010012643.4EC7DE8F1F@git1-us-west.apache.org> Date: Tue, 10 Oct 2017 01:26:43 +0000 (UTC) archived-at: Tue, 10 Oct 2017 01:26:45 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1398#discussion_r143613282 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -2070,6 +1994,20 @@ public static void dropDatabaseDirectory(String dbName, String storePath) } } + public static DataType getDataType(char type) { --- End diff -- Suggest to move all conversion to DataType enum, including this one and `ColumnPageEncoderMeta.convertType`. And also move `CarbonCommonConstants.BIG_INT_MEASURE` and related constants to DataType enum also. ---