carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1436: [CARBONDATA-1617] Merging carbonindex files w...
Date Mon, 30 Oct 2017 11:46:00 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1436#discussion_r147680430
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
---
    @@ -48,9 +48,11 @@
       protected static final String CARBON_UPDATE_DELTA_EXT = ".updatedelta";
       protected static final String DATA_PART_PREFIX = "part-";
       protected static final String BATCH_PREFIX = "_batchno";
    -  protected static final String INDEX_FILE_EXT = ".carbonindex";
       protected static final String DELETE_DELTA_FILE_EXT = ".deletedelta";
     
    +  public static final String INDEX_FILE_EXT = ".carbonindex";
    --- End diff --
    
    Can we change it to package private static member?
    And can you change the above member from line 36 to 51 also


---

Mime
View raw message