carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sounakr <...@git.apache.org>
Subject [GitHub] carbondata pull request #1437: [CARBONDATA-1618] Fix issue of not support ta...
Date Fri, 27 Oct 2017 10:44:01 GMT
Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1437#discussion_r147354409
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
    @@ -287,7 +288,8 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser
{
           groupCols,
           Some(colProps),
           bucketFields: Option[BucketFields],
    -      partitionInfo)
    +      partitionInfo,
    +      comment)
    --- End diff --
    
    Please check if the all the callers for TableModel case class is covered the "comment"
parameter or have handled it. For e.g. in def createTableInfoFromParam.


---

Mime
View raw message