carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1433: [CARBONDATA-1517]- Pre Aggregate Create Table...
Date Wed, 25 Oct 2017 06:25:49 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1433#discussion_r146764194
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
    @@ -110,6 +111,40 @@ class CarbonFileMetastore extends CarbonMetaStore {
         }
       }
     
    +  /**
    +   * This method will overwrite the existing schema and update it with the given details
    +   *
    +   * @param newTableIdentifier
    +   * @param thriftTableInfo
    +   * @param carbonStorePath
    +   * @param sparkSession
    +   */
    +  def updateTableSchemaForPreAgg(newTableIdentifier: CarbonTableIdentifier,
    +      oldTableIdentifier: CarbonTableIdentifier,
    +      thriftTableInfo: org.apache.carbondata.format.TableInfo,
    +      carbonStorePath: String)(sparkSession: SparkSession): String = {
    +    val absoluteTableIdentifier = AbsoluteTableIdentifier.fromTablePath(carbonStorePath)
    --- End diff --
    
    check  if you can reuse the code of `updateTableSchemaForAlter`


---

Mime
View raw message