carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ashwini-krishnakumar <...@git.apache.org>
Subject [GitHub] carbondata pull request #1390: [CARBONDATA-1360] fix for update table failur...
Date Mon, 23 Oct 2017 13:37:38 GMT
GitHub user ashwini-krishnakumar reopened a pull request:

    https://github.com/apache/carbondata/pull/1390

    [CARBONDATA-1360]  fix for update table failures for struct data type

    Problem: updates not working for complex data type struct. escape characters used for
internal delimiters was causing the update failures and null updates .
    Fix : escape characters used for internal delimiters was causing the update failures and
null updates to fix this escape characters are replaced before update processing.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ashwini-krishnakumar/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1390
    
----
commit 372bfe0be937c805c7c165865391e9309d56dd34
Author: ashwini-krishnakumar <ashwini.krishnakumar@gmail.com>
Date:   2017-09-27T12:31:08Z

    [CARBONDATA-1360] fix for update table failures for struct data type
    
    Problem: updates not working for complex data type .
    Fix : escaspe characters used for internal demiliters was causing the update failures
and null updates to fix this escaspe characters are replaced before update processing.
    Changes :1. added testcase to test update on complex struct data type with two level delimiters
             2. fixed update failures for array and struct datatype
             3. added testcase for update with array data type

----


---

Mime
View raw message