carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1413: [CARBONDATA-1548] resolved bug for creating t...
Date Fri, 20 Oct 2017 04:32:38 GMT
Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1413#discussion_r145876968
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -233,10 +233,17 @@ object CarbonSource {
        * @return
        */
       def updateCatalogTableWithCarbonSchema(tableDesc: CatalogTable,
    -      sparkSession: SparkSession): CatalogTable = {
    +                                         sparkSession: SparkSession): CatalogTable =
{
         val metaStore = CarbonEnv.getInstance(sparkSession).carbonMetastore
         val storageFormat = tableDesc.storage
         val properties = storageFormat.properties
    +    tableDesc.storage.properties.get("tableName") match {
    --- End diff --
    
    @ravipesala 1.tableName validation does not take place in parser when you datasource ddl
    2.test case is already there in carbondatasource suite i just modified it to check that
when exception is thrown table should not be there in store


---

Mime
View raw message