carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1404: [CARBONDATA-1541] There are some errors when ...
Date Thu, 12 Oct 2017 06:59:20 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1404#discussion_r144207692
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/DataLoadProcessBuilder.java
---
    @@ -56,7 +56,7 @@ public AbstractDataLoadProcessorStep build(CarbonLoadModel loadModel,
String[] s
           CarbonIterator[] inputIterators) throws Exception {
         CarbonDataLoadConfiguration configuration = createConfiguration(loadModel, storeLocation);
         SortScopeOptions.SortScope sortScope = CarbonDataProcessorUtil.getSortScope(configuration);
    -    if (!configuration.isSortTable() || sortScope.equals(SortScopeOptions.SortScope.NO_SORT))
{
    +    if (sortScope.equals(SortScopeOptions.SortScope.NO_SORT)) {
    --- End diff --
    
    I do not think this is the correct place to modify. You should correct the place where
bad record logger is called


---

Mime
View raw message