carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...
Date Thu, 12 Oct 2017 06:50:54 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r144206409
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java
---
    @@ -45,14 +45,13 @@
        * @param blockletId sequence number of blocklet in the block
        */
       void onBlockletEnd(int blockletId);
    -
       /**
        * Add the column pages row to the datamap, order of pages is same as `indexColumns`
in
        * DataMapMeta returned in DataMapFactory.
        *
        * Implementation should copy the content of `pages` as needed, because `pages` memory
        * may be freed after this method returns, if using unsafe column page.
        */
    -  void onPageAdded(int blockletId, int pageId, ColumnPage[] pages);
    +  void onPageAdded(int blockletId, int pageId, ColumnPage[] pages, String directoryPath);
    --- End diff --
    
    instead of passing the directoryPath for every call, better add init method and pass the
segment directory path to it.


---

Mime
View raw message