carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1410: [WIP] FG interface updates
Date Wed, 11 Oct 2017 14:40:19 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1410#discussion_r144032502
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapType.java ---
    @@ -0,0 +1,21 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.datamap;
    +
    +public enum DataMapType {
    +  CG,FG;
    --- End diff --
    
    If we have CoarseGrainDataMap and FineGrainDataMap interface, this enum is not needed.
see next comment


---

Mime
View raw message