carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1410: [WIP] FG interface updates
Date Wed, 11 Oct 2017 14:39:20 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1410#discussion_r144032204
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
    @@ -26,7 +26,7 @@
     /**
      * Datamap is an entity which can store and retrieve index data.
      */
    -public interface DataMap {
    +public interface DataMap<T extends Blocklet> {
    --- End diff --
    
    If there are only FG and CG datamap, I prefer to make another interface for FG datamap
instead of adding generic. So there will be CoarseGrainDataMap and FineGrainDataMap interface


---

Mime
View raw message