carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xubo245 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1362: [CARBONDATA-1444] Support Boolean data type
Date Wed, 11 Oct 2017 01:00:26 GMT
Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r143890311
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -271,6 +267,18 @@ private static ColumnPage newIntPage(TableSpec.ColumnSpec columnSpec,
int[] intD
         return columnPage;
       }
     
    +  private static ColumnPage newBooleanPage(TableSpec.ColumnSpec columnSpec, byte[] booleanData)
{
    +    ColumnPage columnPage = createPage(columnSpec, BOOLEAN, booleanData.length);
    --- End diff --
    
    ok, I use newBytePage to replace newBooleanPage


---

Mime
View raw message