carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...
Date Tue, 10 Oct 2017 12:24:51 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r143710464
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
---
    @@ -219,4 +225,27 @@ public DataMapMeta getMeta() {
         // TODO: pass SORT_COLUMNS into this class
         return null;
       }
    +
    +  @Override public SegmentProperties getSegmentProperties(String segmentId) throws IOException
{
    +    SegmentProperties segmentProperties = null;
    --- End diff --
    
    SegmentProperties need to be cached, it shouldn't read from disk always


---

Mime
View raw message