carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1362: [CARBONDATA-1444] Support boolean data type
Date Tue, 10 Oct 2017 01:48:40 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r143615171
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -530,6 +546,11 @@ private void putNull(int rowId) {
       public abstract byte[] getShortIntPage();
     
       /**
    +   * Get boolean value page
    +   */
    +  public abstract byte[] getBooleanPage();
    --- End diff --
    
    The same as above, you can implement this function here instead of abstract


---

Mime
View raw message