carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1362: [CARBONDATA-1444] Support boolean data type
Date Tue, 10 Oct 2017 01:45:56 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r143614968
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -436,6 +439,11 @@ public void putData(int rowId, Object value) {
       public abstract void putShortInt(int rowId, int value);
     
       /**
    +   * Set boolean value at rowId
    +   */
    +  public abstract void putBoolean(int rowId, boolean value);
    --- End diff --
    
    Since internally boolean is stored as byte, so you can implement this function to call
`putByte` instead of abstract function


---

Mime
View raw message