carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1362: [CARBONDATA-1444] Support boolean
Date Tue, 10 Oct 2017 01:42:59 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r143614716
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -206,6 +199,7 @@ public static ColumnPage newPage(TableSpec.ColumnSpec columnSpec,
DataType dataT
           }
         } else {
           switch (dataType) {
    +        case BOOLEAN:
    --- End diff --
    
    It is better to add a `newBooleanPage`, otherwise `newBytePage` internal will store the
data type as byte instead of boolean


---

Mime
View raw message