carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ...
Date Tue, 10 Oct 2017 01:28:46 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1398#discussion_r143613491
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataFileFooterConverter.java
---
    @@ -123,6 +123,25 @@ private BlockletInfo getBlockletInfo(
       }
     
       @Override public List<ColumnSchema> getSchema(TableBlockInfo tableBlockInfo)
throws IOException {
    -    return null;
    +    FileHolder fileReader = null;
    --- End diff --
    
    Is this change related to this PR? Can you add comment to describe the intention of this
function in its abstract interface?


---

Mime
View raw message