carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ...
Date Tue, 10 Oct 2017 01:26:43 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1398#discussion_r143613282
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -2070,6 +1994,20 @@ public static void dropDatabaseDirectory(String dbName, String
storePath)
         }
       }
     
    +  public static DataType getDataType(char type) {
    --- End diff --
    
    Suggest to move all conversion to DataType enum, including this one and `ColumnPageEncoderMeta.convertType`.
And also move `CarbonCommonConstants.BIG_INT_MEASURE` and related constants to DataType enum
also.


---

Mime
View raw message