carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ...
Date Tue, 10 Oct 2017 01:20:32 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1398#discussion_r143612778
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
---
    @@ -214,6 +218,42 @@ public void setNumberOfPages(int numberOfPages) {
         for (int i = 0; i < mSize; i++) {
           output.writeInt(measureChunksLength.get(i));
         }
    +    // Serialize datachunks as well for older versions like V1 and V2
    --- End diff --
    
    Can you wrap this logic into a function and mentioning it is for V1 and V2 serialization
only, I think it will be more readable


---

Mime
View raw message