Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ABCE7200CFC for ; Thu, 28 Sep 2017 13:45:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AA42E1609CD; Thu, 28 Sep 2017 11:45:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F04B81609C2 for ; Thu, 28 Sep 2017 13:45:51 +0200 (CEST) Received: (qmail 80406 invoked by uid 500); 28 Sep 2017 11:45:51 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 80397 invoked by uid 99); 28 Sep 2017 11:45:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Sep 2017 11:45:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 142A5F3287; Thu, 28 Sep 2017 11:45:51 +0000 (UTC) From: manishgupta88 To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org Message-ID: Subject: [GitHub] carbondata pull request #1395: [CARBONDATA-1533] Fixed decimal data load fai... Content-Type: text/plain Date: Thu, 28 Sep 2017 11:45:51 +0000 (UTC) archived-at: Thu, 28 Sep 2017 11:45:52 -0000 GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/1395 [CARBONDATA-1533] Fixed decimal data load fail issue and restricted max characters per column 1. Fixed data load failure when both precision and data falls in integer range for decimal data type Analysis: When precision is <=9 for decimal data type then by default integer type is selected for storing decimal data. Data is further compressed by checking min and max value range of data. If data is such that it falls in the Integer range only then exception is thrown during data load as encode method is not handling integer data type data during data load. 2. Restricted max characters per column to 32000 as we use short to store the length of each column Analysis: Short data type is used to store length of each column in unsafe carbon row while writing data to off heap. If length is more than Short value then values goes into negative and while reading the same data negative array size exception is thrown. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manishgupta88/carbondata decimal_int_range_issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1395.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1395 ---- commit 5066935dc5cd6f9873cda794b2e71d9431983996 Author: manishgupta88 Date: 2017-09-28T11:33:46Z 1. Fixed data load bug failure when both precision and data fal in integer range for decimal data type 2. Restricted max characters per column to 32000 as we use short to store the length of each column ---- ---