Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EDA3B200D0C for ; Wed, 20 Sep 2017 13:40:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EC2811609E2; Wed, 20 Sep 2017 11:40:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 30A1E1609E1 for ; Wed, 20 Sep 2017 13:40:38 +0200 (CEST) Received: (qmail 59685 invoked by uid 500); 20 Sep 2017 11:40:37 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 59676 invoked by uid 99); 20 Sep 2017 11:40:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 11:40:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 48A88F1741; Wed, 20 Sep 2017 11:40:35 +0000 (UTC) From: ravipesala To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1374: [CARBONDATA-1491] Dictionary_exclude columns ... Content-Type: text/plain Message-Id: <20170920114036.48A88F1741@git1-us-west.apache.org> Date: Wed, 20 Sep 2017 11:40:35 +0000 (UTC) archived-at: Wed, 20 Sep 2017 11:40:39 -0000 Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1374#discussion_r139945003 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -617,7 +617,13 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser { // by default consider all String cols as dims and if any dictionary include isn't present then // add it to noDictionaryDims list. consider all dictionary excludes/include cols as dims fields.foreach { field => - if (dictIncludeCols.exists(x => x.equalsIgnoreCase(field.column))) { + if (dictExcludeCols.exists(x => x.equalsIgnoreCase(field.column))) { + val dataType = DataTypeUtil.getDataType(field.dataType.get.toUpperCase()) + if (dataType != DataType.DATE) { --- End diff -- how about timestamp? ---