Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 685AA200D0C for ; Wed, 20 Sep 2017 13:07:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 66D311609E2; Wed, 20 Sep 2017 11:07:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F41F1609E1 for ; Wed, 20 Sep 2017 13:07:42 +0200 (CEST) Received: (qmail 51320 invoked by uid 500); 20 Sep 2017 11:07:41 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 51309 invoked by uid 99); 20 Sep 2017 11:07:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 11:07:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9B9E1F32C3; Wed, 20 Sep 2017 11:07:41 +0000 (UTC) From: gvramana To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1101: [CARBONDATA-1143] fix for null struct type Content-Type: text/plain Message-Id: <20170920110741.9B9E1F32C3@git1-us-west.apache.org> Date: Wed, 20 Sep 2017 11:07:41 +0000 (UTC) archived-at: Wed, 20 Sep 2017 11:07:43 -0000 Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1101#discussion_r139939203 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/StructDataType.java --- @@ -145,7 +146,7 @@ public void setSurrogateIndex(int surrIndex) { throws IOException, DictionaryGenerationException { dataOutputStream.writeInt(children.size()); if (input == null) { - dataOutputStream.writeInt(children.size()); + // dataOutputStream.writeInt(children.size()); --- End diff -- remove the comment ---