Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: cenyuhai <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1356-carbondata@git.apache.org>
In-Reply-To: <git-pr-1356-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...
Content-Type: text/plain
Message-Id: <20170913152939.6F27BF558D@git1-us-west.apache.org>
Date: Wed, 13 Sep 2017 15:29:39 +0000 (UTC)
archived-at: Wed, 13 Sep 2017 15:29:41 -0000

Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1356#discussion_r138654019
  
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java ---
    @@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, CarbonColumn carbonColumn)
           case LONG:
             return new LongWritable((long) obj);
           case SHORT:
    -        return new ShortWritable((Short) obj);
    +        return new ShortWritable((short) obj);
           case DATE:
    -        return new DateWritable(new Date(((Integer) obj).longValue()));
    +        Calendar c = Calendar.getInstance();
    +        c.setTime(new Date(0));
    --- End diff --
    
    Does it mean current time? and then reset the year to current year?


---