Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B790200D0B for ; Wed, 13 Sep 2017 05:53:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7AD591609C8; Wed, 13 Sep 2017 03:53:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B83CF1609B4 for ; Wed, 13 Sep 2017 05:53:00 +0200 (CEST) Received: (qmail 6712 invoked by uid 500); 13 Sep 2017 03:52:59 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 6703 invoked by uid 99); 13 Sep 2017 03:52:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Sep 2017 03:52:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A1FFCF56C6; Wed, 13 Sep 2017 03:52:59 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1273: [CARBONDATA-1400] Fix bug of array column out... Content-Type: text/plain Message-Id: <20170913035259.A1FFCF56C6@git1-us-west.apache.org> Date: Wed, 13 Sep 2017 03:52:59 +0000 (UTC) archived-at: Wed, 13 Sep 2017 03:53:01 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1273#discussion_r138518998 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java --- @@ -79,29 +82,29 @@ public void setDoublePage(double[] doubleData) { /** * Create a new column page for decimal page */ - static ColumnPage newDecimalColumnPage(byte[] lvEncodedBytes, int scale, int precision) - throws MemoryException { + static ColumnPage newDecimalColumnPage(TableSpec.ColumnSpec columnSpec, byte[] lvEncodedBytes, + int scale, int precision) throws MemoryException { --- End diff -- I will try, but it is a temporary solution. I think the correct way is to make DataType a class instead of enum, and keep precision and scale in that. ---