Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24C71200CFE for ; Fri, 8 Sep 2017 16:31:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 23935160C3A; Fri, 8 Sep 2017 14:31:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 694B31609D7 for ; Fri, 8 Sep 2017 16:31:18 +0200 (CEST) Received: (qmail 98807 invoked by uid 500); 8 Sep 2017 14:31:16 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 98795 invoked by uid 99); 8 Sep 2017 14:31:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Sep 2017 14:31:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id ECD17F32B0; Fri, 8 Sep 2017 14:31:14 +0000 (UTC) From: jackylk To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1265: [CARBONDATA-1128] Add encoding for non-dictio... Content-Type: text/plain Message-Id: <20170908143114.ECD17F32B0@git1-us-west.apache.org> Date: Fri, 8 Sep 2017 14:31:14 +0000 (UTC) archived-at: Fri, 08 Sep 2017 14:31:19 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1265#discussion_r137805419 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java --- @@ -366,7 +364,7 @@ private BitSet setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD BitSet bitSet = new BitSet(numerOfRows); byte[][] filterValues = this.filterRangeValues; // binary search can only be applied if column is sorted - if (isNaturalSorted) { + if (isNaturalSorted && !dimensionColumnDataChunk.isNoDicitionaryColumn()) { --- End diff -- In this PR, plain value (no dictionary) is using adaptive encoding, it is not sorted. I think it will make store size smaller but for some filter query it will be slower. Any suggestion? ---