Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1308-carbondata@git.apache.org>
In-Reply-To: <git-pr-1308-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1308: [CARBONDATA-1440]Fix coverity issues
Content-Type: text/plain
Message-Id: <20170906124749.6425EF3280@git1-us-west.apache.org>
Date: Wed,  6 Sep 2017 12:47:49 +0000 (UTC)
archived-at: Wed, 06 Sep 2017 12:47:51 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1308#discussion_r137256155
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java ---
    @@ -223,39 +223,39 @@ public BigDecimal getDecimal(int rowId) {
       @Override
       public int[] getIntPage() {
         int[] data = new int[getPageSize()];
    -    for (int i = 0; i < data.length; i++) {
    +    for (long i = 0; i < data.length; i++) {
           long offset = i << intBits;
    -      data[i] = CarbonUnsafe.getUnsafe().getInt(baseAddress, baseOffset + offset);
    +      data[(int)i] = CarbonUnsafe.getUnsafe().getInt(baseAddress, baseOffset + offset);
         }
         return data;
       }
     
       @Override
       public long[] getLongPage() {
         long[] data = new long[getPageSize()];
    -    for (int i = 0; i < data.length; i++) {
    +    for (long i = 0; i < data.length; i++) {
           long offset = i << longBits;
    -      data[i] = CarbonUnsafe.getUnsafe().getLong(baseAddress, baseOffset + offset);
    +      data[(int)i] = CarbonUnsafe.getUnsafe().getLong(baseAddress, baseOffset + offset);
         }
         return data;
       }
     
       @Override
       public float[] getFloatPage() {
         float[] data = new float[getPageSize()];
    -    for (int i = 0; i < data.length; i++) {
    +    for (long i = 0; i < data.length; i++) {
    --- End diff --
    
    why this modification is needed?


---