carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1377: [CARBONDATA-1504] Fixed refresh of segments i...
Date Thu, 28 Sep 2017 05:05:53 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1377#discussion_r141526946
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/DataMapWriterSuite.scala
---
    @@ -41,9 +41,9 @@ class C2DataMapFactory() extends DataMapFactory {
     
       override def fireEvent(event: ChangeEvent[_]): Unit = ???
     
    -  override def clear(segmentId: String): Unit = ???
    +  override def clear(segmentId: String): Unit = {}
    --- End diff --
    
    Earlier clear was not calling, but not it is called so implementation has to be provided
otherwise testcase fails.


---

Mime
View raw message