carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Date Wed, 27 Sep 2017 14:37:47 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1382#discussion_r141363530
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
    @@ -190,6 +190,14 @@ class AlterTableColumnSchemaGenerator(
     
       val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
     
    +  def checkSortColumn(columnName: String): Boolean = {
    +    val sortColumns = alterTableModel.tableProperties.get("sort_columns")
    +    if(sortColumns.isDefined) {
    +      sortColumns.get.contains(columnName)
    +    } else {
    +      true
    --- End diff --
    
    Shouldn't it be false?


---

Mime
View raw message