carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1376: [CARBONDATA-1505] Get the detailed blocklet i...
Date Wed, 27 Sep 2017 13:59:15 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1376#discussion_r141351076
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
---
    @@ -78,8 +90,59 @@ public DataMapWriter createWriter(String segmentId) {
                 new TableBlockIndexUniqueIdentifier(identifier, segmentId, listFiles[i].getName()));
           }
         }
    +    return tableBlockIndexUniqueIdentifiers;
    +  }
     
    -    return cache.getAll(tableBlockIndexUniqueIdentifiers);
    +  /**
    +   * Get the blocklet detail information based on blockletid, blockid and segmentid.
This method is
    +   * exclusively for BlockletDataMapFactory as detail information is only available in
this default
    +   * datamap.
    +   * @param blocklets
    --- End diff --
    
    remove javadoc that is empty


---

Mime
View raw message