carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1376: [CARBONDATA-1505] Get the detailed blocklet i...
Date Wed, 27 Sep 2017 13:54:57 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1376#discussion_r141349763
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
    @@ -561,7 +567,7 @@ protected Expression getFilterPredicates(Configuration configuration)
{
         return resultFilterredBlocks;
       }
     
    -  private org.apache.carbondata.hadoop.CarbonInputSplit convertToCarbonInputSplit(Blocklet
blocklet)
    +  private CarbonInputSplit convertToCarbonInputSplit(DetailedBlocklet blocklet)
           throws IOException {
         blocklet.updateLocations();
         org.apache.carbondata.hadoop.CarbonInputSplit split =
    --- End diff --
    
    Why not just use `CarbonInputSplit` instead of `org.apache.carbondata.hadoop.CarbonInputSplit`


---

Mime
View raw message