carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1374: [CARBONDATA-1491] Dictionary_exclude columns ...
Date Wed, 20 Sep 2017 13:37:24 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1374#discussion_r139970827
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
    @@ -617,7 +617,13 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser
{
         // by default consider all String cols as dims and if any dictionary include isn't
present then
         // add it to noDictionaryDims list. consider all dictionary excludes/include cols
as dims
         fields.foreach { field =>
    -      if (dictIncludeCols.exists(x => x.equalsIgnoreCase(field.column))) {
    +      if (dictExcludeCols.exists(x => x.equalsIgnoreCase(field.column))) {
    +        val dataType = DataTypeUtil.getDataType(field.dataType.get.toUpperCase())
    +        if (dataType != DataType.DATE) {
    --- End diff --
    
    yes, please add


---

Mime
View raw message