carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1362: [CARBONDATA-1444]Support boolean
Date Sun, 17 Sep 2017 11:01:30 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r139307667
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/bool/BooleanEncoderMeta.java
---
    @@ -0,0 +1,40 @@
    +package org.apache.carbondata.core.datastore.page.encoding.bool;
    +
    +import java.io.DataInput;
    +import java.io.DataOutput;
    +import java.io.IOException;
    +
    +import org.apache.carbondata.core.datastore.TableSpec;
    +import org.apache.carbondata.core.datastore.page.encoding.ColumnPageEncoderMeta;
    +import org.apache.carbondata.core.datastore.page.statistics.SimpleStatsResult;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.metadata.schema.table.Writable;
    +
    +public class BooleanEncoderMeta extends ColumnPageEncoderMeta implements Writable {
    +  private String compressorName;
    +
    +  public BooleanEncoderMeta() {
    +  }
    +
    +  public BooleanEncoderMeta(TableSpec.ColumnSpec columnSpec, DataType storeDataType,
    +                            SimpleStatsResult stats, String compressorName) {
    +    super(columnSpec,storeDataType,stats,compressorName);
    +    this.compressorName = compressorName;
    --- End diff --
    
    compressorName is already stored in ColumnPageEncoderMeta, this BooleanEncoderMeta is
not required.


---

Mime
View raw message