carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1362: [CARBONDATA-1444]Support boolean
Date Sun, 17 Sep 2017 10:59:15 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r139307631
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
    @@ -92,6 +90,10 @@ public ColumnPageDecoder createDecoder(List<Encoding> encodings,
List<ByteBuffer
           RLEEncoderMeta metadata = new RLEEncoderMeta();
           metadata.readFields(in);
           return new RLECodec().createDecoder(metadata);
    +    } else if (encoding == BOOL_BYTE) {
    +      BooleanEncoderMeta metadata=new BooleanEncoderMeta();
    --- End diff --
    
    I think it is better to use RLE on byte, since it just has two values


---

Mime
View raw message