carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...
Date Fri, 15 Sep 2017 11:04:39 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r139122030
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java
---
    @@ -32,7 +32,12 @@
       /**
        * End of block notification
        */
    -  void onBlockEnd(String blockId);
    +  void onBlockEnd(String blockId, String directoryPath);
    +
    +  /**
    +   * End of block notification when index got created.
    +   */
    +  void onBlockEndWithIndex(String blockId, String directoryPath);
    --- End diff --
    
    I did not get the meaning of index. it is supposed to be independent of other indexes.
I think onBlockEnd event is enough for writing the index file.


---

Mime
View raw message