carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aniketadnaik <...@git.apache.org>
Subject [GitHub] carbondata pull request #1352: [CARBONDATA-1174] Streaming Ingestion - schem...
Date Fri, 15 Sep 2017 07:55:45 GMT
Github user aniketadnaik commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1352#discussion_r139085031
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/streaming/CarbonStreamingCommitInfo.java
---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.streaming;
    +
    +/**
    + * Commit info for streaming writes
    + * The commit info can be used to recover valid offset in the file
    + * in the case of write failure.
    + */
    +public class CarbonStreamingCommitInfo {
    +
    +  private String dataBase;
    +
    +  private String table;
    --- End diff --
    
    This file is from previous PR. I guess my recent rebase has moved the HEAD for streaming_ingest
branch in my private repo. This needs to be corrected. Please hold off your review . On a
side note - this class is just to provide a framework for storing commit info, actual values
can be changed at the time of implementation.


---

Mime
View raw message