carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1321: [CARBONDATA-1438] Unify the sort column and s...
Date Thu, 14 Sep 2017 08:48:23 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1321#discussion_r138832339
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -432,7 +440,9 @@ case class LoadTable(
           val dateFormat = options.getOrElse("dateformat", null)
           ValidateUtil.validateDateFormat(dateFormat, table, tableName)
           val maxColumns = options.getOrElse("maxcolumns", null)
    -      val sortScope = options.getOrElse("sort_scope", null)
    +
    +      val tableProperties = table.getTableInfo.getFactTable.getTableProperties
    +      val sortScope = if (null == tableProperties) null else tableProperties.get("sort_scope")
    --- End diff --
    
    If tableProperties is null, it need to use default sort scope, right?


---

Mime
View raw message