carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1321: [CARBONDATA-1438] Unify the sort column and s...
Date Thu, 14 Sep 2017 08:43:42 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1321#discussion_r138831288
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -172,6 +173,13 @@ case class CreateTable(cm: TableModel) extends RunnableCommand {
     
         val tableInfo: TableInfo = TableNewProcessor(cm)
     
    +    // Add validation for sort scope when create table
    +    val sortScope = tableInfo.getFactTable.getTableProperties.get("sort_scope")
    +    if (null != sortScope && !CarbonUtil.isValidSortOption(sortScope)) {
    +      throw new InvalidConfigurationException("The sort scope " + sortScope
    --- End diff --
    
    suggest to change to 
    ```
    s"Passing invalid sort scope '$sortScope', valid sort scopes are 'NO_SORT', 'BATCH_SORT',
'LOCAL_SORT' or 'GLOBAL_SORT' "
    ```


---

Mime
View raw message